[New! Program] Voxinator: A Rockband Vocals Visualizer

  • This topic is empty.
Viewing 15 posts - 16 through 30 (of 69 total)
  • Author
    Posts
  • #434336
    TrojanNemo
    Participant

      My understanding is it doesn’t matter what notes are used as long as the lyrics are unpitched, the game treats them the same.

      #434344

      Well I’ve given up trying to figure this chart out.

      If someone wants to explain in detail why this chart is the way it is then I’ll look further into fixing it.

      But it’s the only chart I’ve seen like that so I’m not really concerned with it.

       

      The program works on like 99% of charts.

      #434351
      TrojanNemo
      Participant

        Again, work as much or as little as you want. But if your code doesn’t work with this file, you should look at why your code fails, rather than saying “well, it’s not my code’s fault, it’s the file.” Because that file works fine in game (I’ve played it) and it works fine with C3 CON Tools.

         

        http://www.keepitfishy.com/rb3/SirMix-a … Vocals.txt

        http://www.keepitfishy.com/rb3/SirMix-a … onies1.txt

        http://www.keepitfishy.com/rb3/SirMix-a … onies2.txt

        http://www.keepitfishy.com/rb3/SirMix-a … onies3.txt

         

        I don’t remember from when I looked at your source code, but there is no reason that the unpitched notes being on a note that you don’t expect or that you consider “weird” should break the program working. And if it does, doesn’t Visual Studio tell you why it’s causing an exception when you debug?

        #434355
        Farottone
        Keymaster
          Again, work as much or as little as you want. But if your code doesn’t work with this file, you should look at why your code fails, rather than saying “well, it’s not my code’s fault, it’s the file.” Because that file works fine in game

           

          That means little in terms of MIDI format handling. The game can read notes of any channel in example, while analysing the file with any library you may or may not need to account for that. I’d say that for the first day of release or os he’s done pretty well all in all. <img decoding=” src=”/wp-content/uploads/invision_emoticons/default_SA_smile.gif”>

          #434358
          TrojanNemo
          Participant
            I’d say that for the first day of release or os he’s done pretty well all in all. <img decoding=” src=”/wp-content/uploads/invision_emoticons/default_SA_smile.gif” />

             

            That is certainly true. But it’s not clear whether he’s got a lot of programming knowledge and is about to drop some teachin’ on me, which I certainly need, or if he’s a beginner needing some guidance. I assumed the latter and was offering it, but perhaps I should wait until help is asked for instead. <img decoding=” src=”/wp-content/uploads/invision_emoticons/default_SA_smile.gif” />

            #434372

            My problem isn’t with understanding the code. My problem is understanding how charting works. If I don’t understand how charting works then my code obviously won’t work properly.

             

            I’m not really getting much help with understanding how charting works.

            You just keep saying “well if your program was any decent then it should work all the time” but that doesn’t help me.

             

            So I’ll offer up some questions that perhaps were missed before:

            1. Why are talkies charted without the “#” or “^” marker?

            2. Why chart any pitch to a talky? Isn’t that unnecessary work?

            3. Why when importing the midi to reaper 4.22, PART VOCALS has no text events?

            4. Why can the start phrase marker on A8/A#8 come AFTER a charted note not already part of a phrase?

            5. Why does HARM 3 not have phrase markers? Does it just use the ones in HARM 2?

            6. Why are there TWO PART VOCALS >tracks< ? Does the game just combine the tracks or does it ignore one? I understand there being multiple channels but this is multiple tracks showing up in reaper 4.22.

             

             [C#2]Lit-<--- [C#2]tle [C#2]in [C#2]the [C#2]mid- [C#2]dle --->
            [C#2]But<--- [C#2]you [C#2]got [C#2]much [C#2]back --->

            #434378
            Farottone
            Keymaster
              My problem isn’t with understanding the code. My problem is understanding how charting works. If I don’t understand how charting works then my code obviously won’t work properly.

               

              I’m not really getting much help with understanding how charting works.

              You just keep saying “well if your program was any decent then it should work all the time” but that doesn’t help me.

               

              So I’ll offer up some questions that perhaps were missed before:

              1. Why are talkies charted without the “#” or “^” marker?

              2. Why chart any pitch to a talky? Isn’t that unnecessary work?

              3. Why when importing the midi to reaper 4.22, PART VOCALS has no text events?

              4. Why can the start phrase marker on A8/A#8 come AFTER a charted note not already part of a phrase?

              5. Why does HARM 3 not have phrase markers? Does it just use the ones in HARM 2?

              6. Why are there TWO PART VOCALS >tracks

               

               [C#2]Lit-
              [C#2]But

               

              Well, to be fair, half of what’s in there is answered by the docs. <img decoding=” src=”/wp-content/uploads/invision_emoticons/default_SA_wink.gif”> I’ll tackle what’s not:

              3) That’s strange, it should have at least the animation text events ([play], [idle], etc.).

              4) A8 doesn’t exist in MIDI.

              6) There aren’t. When you import a MIDI make sure that in Options > Preferences > MIDI, Import multichannel MIDI files is set to Always ask…. When you’re prompted, have Reaper import multichannel items in one track.

              #434380

              Thanks for the help.

              I had Reaper set to import on separate tracks instead of single track multichannel.

              Now the chart looks correct with text events etc.

               

              Ignore the octave number 8 I put for that question. The point was the marker.

              I was originally using http://pksage.com/rbndocs/index.php but I think I should be looking at the PDF.

               

              Sorry if I came off as lazy but I’ve never authored vocals before so I never looked at that part in the PDF.

              #434381
              Farottone
              Keymaster
                Thanks for the help.

                I had Reaper set to import on separate tracks instead of single track multichannel.

                Now the chart looks correct with text events etc.

                 

                Ignore the octave number 8 I put for that question. The point was the marker.

                 

                For harmony phrase markers check the docs here, to understand how they work:

                http://pksage.com/rbndocs/index.php?tit … _Authoring

                Phrase markers in harmony tracks

                 

                I was originally using http://pksage.com/rbndocs/index.php but I think I should be looking at the PDF.

                 

                No no, those are the docs, you’re using the correct reference. The PDF is for authoring, the docs are more a reference, which is what you need.

                 

                Sorry if I came off as lazy

                 

                You didn’t, I think you just planned how to make your program work underestimating the amount of knowledge you need for that, which is a bit because to work on the these projects you need to know at least the basics. I think it’s great we have somebody working on software to interact with game files other than Nemo here, and being the jealous guy that he is he was heavily busting your chops! :excited: But he does so because he went through what you did and had to consult a million docs and ask a million questions. <img decoding=” src=”/wp-content/uploads/invision_emoticons/default_SA_smile.gif”> I’m just saying that you’re approaching this a bit blindly, as if we already didn’t know exactly how MIDI files work, and you shouldn’t: take advantage of the knowledge base we have and you will see that there’s not A LOT that needs to explored still, while understanding the basics will cut down on your coding hours significantly. <img decoding=” src=”/wp-content/uploads/invision_emoticons/default_SA_wink.gif”>

                #434386

                1. Why are talkies charted without the “#” or “^” marker?

                2. Why chart any pitch to a talky? Isn’t that unnecessary work?

                I have proof that the chart is actually charted weird. I won’t say wrong because that might sound a bit mean. It definitely looks weird though and my program is reading the chart right.

                 

                4. Why can the start phrase marker on A8/A#8 come AFTER a charted note not already part of a phrase? It was marked at the same time as the lyric but my program was picking up the lyric first. I just changed the code to not pick up lyrics until a phrase start marker is read.

                 

                3. Why when importing the midi to reaper 4.22, PART VOCALS has no text events?

                6. Why are there TWO PART VOCALS >tracks< ? Does the game just combine the tracks or does it ignore one? I understand there being multiple channels but this is multiple tracks showing up in reaper 4.22. I had an option set wrong in Reaper. Thanks for the help!

                 

                5. Why does HARM 3 not have phrase markers? Does it just use the ones in HARM 2? Read over the docs and phrase markers for HARM 2 / 3 are marked by HARM 1. HARM 2 is only required for static shifting. I will have to change my code to save HARM 1 markers and reuse them for HARM 2 / 3.

                #434390
                TrojanNemo
                Participant
                  1. Why are talkies charted without the “#” or “^” marker?
                  I have proof that the chart is actually charted weird. I won’t say wrong because that might sound a bit mean. It definitely looks weird though and my program is reading the chart right.

                  Whether a lyric is a “talkie” depends on whether it has the # or ^ marker. If it’s not there, it’s not a “talkie”, it’s a pitched lyric. Even if the audio says it should be “talkie”, you as the person interpreting the MIDI represent it as what i’s charted. So yes, that song is missing a lot of unpitched markers. Last I remember this was breaking compatibility with the posted version of the program. Point being there is no way you get to decide if a lyric should be or shouldn’t be pitched. You have to rely on the markers and assume the author did it correctly.

                   

                   

                  4. Why can the start phrase marker on A8/A#8 come AFTER a charted note not already part of a phrase?

                  It was marked at the same time as the lyric but my program was picking up the lyric first. I just changed the code to not pick up lyrics until a phrase start marker is read.

                   

                  NAudio reads the notes two ways: time-wise, from left (earliest in track) to right, and when things are on the same exact start time, from highest note to lowest note (top to bottom in REAPER). So think of this if you ever add things like detecting old (blue) phrase markers, pro drum markers, overdrive, drum fills. They all may and do happen at the same exact start time as the notes underneath, so it’s always better to read the notes “top to bottom”.

                   

                   

                  Nemo here, and being the jealous guy that he is

                   

                  Nonsense. Me jealous? Pfft.

                  #434392

                  Fixed the last issue of it not separating some tracks by phrases.

                  Turns out I was checking for a Note Off event but this midi file (Sir-Mix-A-Lot) was using Note On events marked as note off to end the phrase. So I just added in where it checks for Note Off events OR note on events marked as note off.

                   

                  The last issue left is just getting phrase markers for HARM3.

                  It’s not a problem per se because that’s how the chart is marked but it would look much nicer.

                   

                  I also added back in overdrive marking and taps.

                   

                  Going to do a little more tests and then upload this V3 which seems to be reading every chart normally.

                   

                  edit: V3 is now uploaded and it’s looking mighty fine! :excited:

                  To do list that is just for conveience: Get HARM3/HARM2 markers and write Tap (x10) instead of “tap tap tap tap tap tap tap tap tap tap.”

                  #435561

                  Worked on this a bit more and I got harmony 2/3 phrase markers to show based on harm 1 markers. Same with overdrive. Last thing I need to add is a “tap” condensor so that it shows Tap x10 instead of Tap Tap Tap Tap Tap etc.

                   

                  I’ll release this version as V4 when it’s done.

                  #435574

                  Finishing V4 up nicely but I ran into one last problem.

                   

                  “Jesus of Seburbia” by Green Day has phrase markers on A6 AND A#6 for PART VOCALS. Why is this? I found no mention of this in the RBN documentation.

                   

                  #435575
                  TrojanNemo
                  Participant

                    You’re not going to find RBN documentation for things that were used exclusively prior to RBN being created.

                    All of RB1/RB2 and those era songs have phrase markers at both places, sometimes only one, sometimes both at the same time (stacked). Why? Because Harmonix.

                  Viewing 15 posts - 16 through 30 (of 69 total)
                  • You must be logged in to reply to this topic.
                  Back to top button